Forum Replies Created

Viewing 13 posts - 1 through 13 (of 13 total)
  • Author
    Posts
  • in reply to: Masonry element – flickering on Load More #970017

    I have tried your suggestion Ismael, but when scrolling over the masonry the browser still locks up completely for a couple of seconds. It’s really not a great user experience.

    in reply to: Masonry element – flickering on Load More #967724

    I have this same issue, I have disabled the animation using CSS by following instructions on this thread: https://kriesi.at/support/topic/disable-loading-animation-of-masonry/, but even without the animation, when scrolling over the masonry, the scrolling glitches noticeably. It seems to me that the JavaScript that animates the masonry needs some optimisation, but could you at least provide a way to completely disable the execution of the JavaScript?

    in reply to: Duplicated Social Icons on Mobile #865409

    I have already created a CSS solution that works for me for now but thanks for validating. Look forward to seeing the permanent fix in one of the upcoming releases.

    Thanks again.

    in reply to: Duplicated Social Icons on Mobile #865003

    In addition, as mentioned in the original post, the issue is only visible on screen sizes between 768px and 990px in width, so make sure you are checking on a screen or with your developer tools set to emulate a screen in that size range.

    in reply to: Duplicated Social Icons on Mobile #864898

    Hi Victoria,

    I encountered this on both PHP 7.0.x and PHP 5.6.x.
    Please make sure that you replicate all the theme settings on the site listed in the private area below. More specifically:

    • Main Menu -> Menu Items for mobile: Activate for Smartphones and Tablets (browser width below 990px)
    • header -> Menu and Logo Position: Logo left, Menu below

    Regards,
    Gareth

    • This reply was modified 7 years, 2 months ago by garethlawson.
    in reply to: Duplicated Social Icons on Mobile #864698

    Hi Ismael,

    If you read my original post at the top of the thread, you will see that I went to the effort of creating a new, clean installation of WordPress and Enfold with NO MODIFICATIONS, apart from importing one of the Enfold demos. I am also hosting this myself and made the site accessible to the Enfold team as a proof of concept (see the Private Data in the original post).

    It’s quite frustrating that I have to keep repeating this information. Please feel free to login there and take a look for yourself. Please also read the original post because the issue is only present when a specific combination of settings is used. I explained this in my original post.

    I understand that you must get an overwhelming number of support requests for a theme as popular as Enfold, which is exactly why I went to the effort to validate this issue and to make it as easy as I could for you guys to review it yourselves. If I have not been clear in my communication, please help me to understand how I could better approach something like this for future reference.

    Regards,
    Gareth

    in reply to: Duplicated Social Icons on Mobile #864009

    In a previous reply I asked, “Will you add it into your development pipeline as a bug for fixing please?” You have not responded to that question. Is this not the correct place to report this as a bug Victoria? Or is this not something that the Enfold development team would consider to be worth fixing?

    in reply to: Duplicated Social Icons on Mobile #863484

    Thanks Victoria. I went to so much effort in my original post to make sure I was submitting a valid support request. Please do me a favour and go and reread it. I created a clean install of WordPress and Enfold and the issue is still there.

    By the way, your CSS still leaves a border and a big gap to the right of the hamburger icon. The final CSS I am using to hide the duplicated icons for anyone else who may have this problem is:

    @media only screen and (max-width: 989px) and (min-width: 768px) {
        .responsive.html_mobile_menu_tablet #top .av-logo-container 
    .social_bookmarks {
            display: none !important;
        }
    
        .avia-menu.av_menu_icon_beside {
            padding: 0;
            margin: 0;
            border: 0;
            -webkit-transition: none;
            transition: none;
        }
    }
    • This reply was modified 7 years, 2 months ago by garethlawson.
    in reply to: Duplicated Social Icons on Mobile #863415

    Thanks for the CSS Victoria. Please could you comment on this statement in my original post: ” I know I could hide these with CSS, but I feel that this is a bug in the theme that should be fixed?”

    Surely duplicated icons is a bug? Will you add it into your development pipeline as a bug for fixing please?

    in reply to: Duplicated Social Icons on Mobile #863336

    Thanks for getting back to me Victoria.

    I would like only the ones relevant to the settings I have selected (“Display in top bar at the right”) to be displayed. So, that would be “the ones above the burger menu”.

    Hi @Basilis,

    Your reply came through without any content. All I see is:
    Empty reply

    Was there something you wanted to add?

    Regards,
    Gareth

    • This reply was modified 7 years, 7 months ago by garethlawson.

    Hi @Ismael,

    The problem I faced is that the plugin I used called Mapplic to render a map on the home page cannot use existing pages/posts for the map pin modal content by default, so I had to duplicate the content for a page and for the map pin. This became a big issue because this content was being updated frequently and was becoming a maintenance nightmare.

    So, I found a way to intercept the JavaScript event triggered when a map pin is clicked on the map, and to populate the content of the modal with the contents of an existing page. The content of that page is built using Avia Page Builder like any other page on the site, and I retrieve the content of the page using an ajax request that calls the above function in my child theme’s functions.php file. The content is therefore rendered out into the response by calling the WordPress the_content() method.

    I’ve included an admin link to the page used in my specific example in the private area of this post, so you can see the avia layout. The only thing the Mapplic plugin does is fire the JavaScript event when a map pin is clicked. The rest is done by the custom code I wrote and the rendering of the content is done entirely by WordPress and Enfold. This layout issue is definitely not related to the plugin. It may be related to the way I am rendering the content in my custom code though. Maybe I can explain a bit further what I am seeing in my debugging.

    When the page is requested normally as per the first link in the private area of my previous post, the first if statement evaluates to true, but then both the if statement and the else if statement below that evaluate to false, so the value of $force_close remains false. When I render the content from my custom function, calling WordPress’ the_content() method, the second if statement: if( ! isset( $meta['siblings']['next']['tag'] ) ) evaluates to true and $force_close is set to true (config-templatebuilder/avia-shortcodes/columns.php line 756 – 769). This is where the layout goes wrong, and each column is wrapped in a div.flex_column_table.av-equal-height-column-flextable element instead of the 2 columns (in my case) in the row being wrapped in this element, as represented in the avia advanced layout builder:

                                   /**
    				 * check if row will break into next column 
    				 */
    				if( ( false === $force_close ) && ! empty( avia_sc_columns::$first_atts['min_height'] ) && ( 'av-equal-height-column' ==  avia_sc_columns::$first_atts['min_height'] ) )
    				{
    					if( ! isset( $meta['siblings']['next']['tag'] ) )
    					{
    						$force_close = true;
    					}
    					else if( ( avia_sc_columns::$calculated_size + avia_sc_columns::$size_array[ $meta['siblings']['next']['tag'] ] ) > 1.0 )
    					{
    						$force_close = true;
    					}
    				}

    I have created a temporary workaround by overriding the above file and adding an extra condition: !(defined('DOING_AJAX') && DOING_AJAX) to the first if statement, to prevent the subsequent if (...) { ... } else if { ... } block from being executed at all. I just wondered if someone there could explain why $meta['siblings']['next']['tag'] is not set when rendering the content this way?

    Thanks again,
    Gareth

    Hi @Ismael and Enfold team,

    Thanks for creating a great, easy-to-use theme.

    I have this same issue specifically when I am loading post content via ajax into a modal window. When the content is rendered normally accessing a page, the columns are rendered correctly. The columns rendered correctly until version 4.0.6 and the change in rendering seems to be as a result of a fix implemented in version 4.0.6:
    – fixed: “Equal Height Columns” breaks when columns are not 100% width (e.g. 1/3 1/3)

    I need the rows to have equal height columns. I understand the need for this fix, but what I don’t understand is why I am experiencing this problem only when fetching the content via ajax?

    Based on some debugging, I think that it may be because some hooks are not getting executed as they should when the content is rendered by my custom function. I tried to debug myself and noticed that ShortcodeHelper::$tree property is not set when I do the ajax call, but is set when the page is loaded normally. Consequently when rendering the columns the $meta['siblings']['next'] and $meta['siblings']['previous'] are not being set when the shortcode_handler() method is called in the config-templatebuilder/avia-shortcodes/columns.php file.

    Please let me know if there are any simple ways you know of to trigger the code that will set the above values or if there is something else obvious I am doing wrong here? I have included URLs where both normal page calls and ajax calls can be seen as well as login details in the private part of the message

    Below is code which is called when the content is requested via ajax:

    /**
     * Show mapplic pin information by fetching with ajax
     */
    if (!function_exists('show_mapplic_ajax_content') && !function_exists('show_mapplic_ajax_content')) {
    	add_action('wp_ajax_nopriv_mapplic_ajax_content', 'show_mapplic_ajax_content');
    	add_action('wp_ajax_mapplic_ajax_content', 'show_mapplic_ajax_content');
    
    	function show_mapplic_ajax_content()
    	{
    		$slug = filter_input(INPUT_POST, 'region-slug', FILTER_SANITIZE_STRING);
    
    		if (empty($slug)) {
    			mapplic_ajax_content_error();
    		}
    
    		// query for the about page
    	    $region_page_query = new WP_Query(['pagename' => trim($slug, " \t\n\r\0\x0B/")]);
    	    if (!$region_page_query->have_posts()) {
    	    	mapplic_ajax_content_error();
    	    }
    
    	    $GLOBALS['wp_query'] = $region_page_query;
    
    	    // "loop" through query (even though it's just one page) 
    	    while ($region_page_query->have_posts()) {
    	    	$region_page_query->the_post();
    	        the_content();
    	    }
    
    	    wp_reset_postdata();
    	    die();
    	}
    
    	function mapplic_ajax_content_error()
    	{
    		die(
    			'<strong>Could not retrieve regional information<strong>
    			 <p>There was a problem getting the information related to our presence in this region.
    			 Please try again in a minute or two.</p>'
    		 );
    	}
    }
Viewing 13 posts - 1 through 13 (of 13 total)