Forum Replies Created

Viewing 5 posts - 1 through 5 (of 5 total)
  • Author
    Posts
  • July 1, 2021 at 2:14 am in reply to: Fullwidth Submenu doesnt allow clicking middle nav items on mobile #1308213
    ctadlock

    I deployed both of these changes; the code in functions.php does not work as expected and the CSS change yields a strange result. I dont see that the code change is working at all. I have to back out the changes.

    Given that this issue is not specific to my site and applies to all uses of the theme, how about you just add this functionality to the theme?

    June 23, 2021 at 11:17 pm in reply to: Fullwidth Submenu doesnt allow clicking middle nav items on mobile #1307212
    ctadlock

    That only works for the main menu. I have several additional menus for each section of my website that I want that same behavior applied to. That is why I am using the “fullwidth submenu” control.

    • This reply was modified 3 years, 4 months ago by ctadlock.
    June 22, 2021 at 10:23 pm in reply to: Fullwidth Submenu doesnt allow clicking middle nav items on mobile #1307035
    ctadlock

    The only reason those links in your screenshot work is that they are leaf nodes. There is no way to navigate to any page that is not a leaf node in the menu. Clicking on the menu item will only open/close the menu, it wont navigate to the page.

    REPRO
    1. On an iPhone navigate to https://learn.gototags.com/nfc/hardware/phones
    2. Click the secondary menu “Menu” burger; this will expand the menu
    3.Try to navigate to the “/nfc/chip” page by clicking the “Chip” menu item; the menu item will be expanded to show the children of Chip

    The core issue here is that a mouse click on a menu item needs to either be “open/close” menu OR navigate to page for that menu item. I have seen this solved elsewhere by differentiating between clicking on the text of the menu item and the greater area surrounding the menu item text.

    As for the arrows on the menu items; I have not customized that all all so it must be a part of the the theme.

    February 14, 2019 at 9:13 pm in reply to: Custom 404 Page Conflict With Yoast #1067135
    ctadlock

    I can also confirm this exact issue.
    enfold: 4.5.3
    yoast: 9.5
    php 7.1

    new.gototags.com/blah
    new.gototags.com/not-found/

    UPDATE: A bit more info; these seems to be an issue with Enfold-Yoast together. I tried the 404 plugin below and disabled the Enfold 404. It still didnt work on my site with Enfold, but it did work on my site with another theme.

    https://petersplugins.com/docs/404page/

    • This reply was modified 5 years, 9 months ago by ctadlock.
    December 11, 2017 at 11:30 pm in reply to: Font Awesome 5 #887586
    ctadlock

    OK, got this working after digging into it. Two issues here:

    1. The SVGs provided by Font Awesome 5 are not valid XML. Its an easy fix; open up the SVG file and remove the top XML comment. Ive already submitted a GitHub bug to them to resolve this.
    https://github.com/FortAwesome/Font-Awesome-Pro/issues/926

    2. All of the Font Awesome 5 font families (light, regular, sold, brands) have a font id of “fontawesome-pro”, which makes sense. However the Enfold theme doesn’t seem to support font families. This isn’t an issue if you just want to use one of them as it will use the name “fontawesome-pro”. If you want to use more than one, you need to manually change the font id attribute in the SVG to the name of the actual files for that family; “fa-brands-400”, “fa-light-300”.

    Don’t ever say I didn’t do anything for you.. This was a pain. ;)

  • Author
    Posts
Viewing 5 posts - 1 through 5 (of 5 total)