Forum Replies Created
-
AuthorPosts
-
Hi,
I have the same problem too with Enfold 4.4.1.
I found the reason is the check in Avia_Config_LayerSlider::current_post_needs_layerslider() method (in enfold/config-layerslider/config.php from line 643 on):
if( is_404() || ! ( $post instanceof WP_Post ) ) { return false; }
In order to work with custom 404 page, this check would have to be extended…
Cheers,
Česlav- This reply was modified 6 years, 4 months ago by bluechip1.
Hi Victoria,
I have the same problem on one of my sites. Is the implementation of burger menu for fallback menus planned in near future or is it a feature that likely will not be implemented at all?
Best regards,
ČeslavHi Marco,
Oh yeah, the anonymous function is also the reason why Layer Slider version included in Enfold 4.1.2 breaks on PHP 5.2, but there can be more incompatible code, because Layer Slider does not seem to support PHP 5.2 anymore (PHP 5.3 is required). On the other hand, it might not be a problem on websites not using Layer Slider actively (quote from https://support.kreaturamedia.com/docs/layersliderwp/documentation.html#release-log):
While LayerSlider continues to require PHP 5.3.0 or newer, on the global scope it no longer uses language features that is not available in PHP 5.2.4. This ensures better overall compatibility with WordPress on pages where LayerSlider is not being actively used.
Regards,
ČeslavHi Marco,
You probably already found out, but perhaps someone else will find this information useful: Enfold 4.1.2 won’t run on PHP 5.2, because included Layer Slider version is no more PHP 5.2 compatible.
Regards,
ČeslavHi John,
Sorry it took me so long to get back to you. I created a clean test install for you (WordPress 4.7.5 + Enfold 4.0.7). Link and credentials are provided in private content section.
Steps to reproduce the bug:
1) Go to Theme Options (Enfold) > General Styling
2) Insert hex color value “#0052a2” into any field with color picker.
3) Watch as it dynamically changes to “#0051a2” (ie. green component value is changed from 52 to 51).All the best,
ČeslavHi Lyse,
Now I see. In your first post you mentioned “#ec55d8”, but this color works fine. With “#ec5548” I can reproduce the issue (same as mine).
If you’re feeling adventurous, you can apply the fix that worked for me. You only have to replace one line of JS code in enfold/framework/js/avia_colorpicker.js. On line 127 replace
picker.find('.colorpicker_hex input').val(hexCol).trigger('change');
withavia_cp.AviaColorPickerSetColor(hexCol.substr(1));
With this fix, the color picker pop up window still displays the wrong value, but the main input field keeps any value that is inserted directly into it, so just paste the color value directly into input field like you did before.
Of course, as soon as you update Enfold theme, this change will be gone, so keep a backup of patched avia_colorpicker.js file.
Greetings,
ČeslavHi Victoria,
I’m sorry for hijacking this thread, it seems that I had a different problem than Lyse. My problem was that whenever I inserted the following hex value for color “#0052a2” into any field with a colorpicker, the value has been automatically (via some JavaScript) converted to “#0051a2”. You can try it on your own Enfold installation, I believe this problem is caused by colorpicker JavaScript library that Enfold uses. It has not been maintained since 2009: http://www.eyecon.ro/colorpicker/
I work-arounded the problem by editing avia_colorpicker.js, but I’d like to suggest that your developers update this library to some more up to date version. Here’s a clone of the legacy library by Stefan Petre that I found on GitHub: https://github.com/itsjavi/bootstrap-colorpicker
Greetings,
Česlav- This reply was modified 7 years, 8 months ago by bluechip1. Reason: grammar
Hi Lyse, Hi Victoria,
Is there a solution for this? I have the same problem: when I enter “#0052a2” as “Alternate Content background color” it is automatically changed to “#0051a2”. Minor difference, but nevertheless annoying…
Cheers,
ČeslavHi Yigit,
I can reproduce this problem (mobile menu not scrolling) on your own 2017 demo on my iPhone running mobile Safari 9.0 – just to give you a website you can debug on ;)
I don’t know if you have WP Rocket installed at your demo website, but I have the same problem at my site that has no caching plugin installed and is running Enfold 4.0.3.
Btw. I noticed that this problem seems to only occur on pages that have LayerSlider, so maybe there’s some conflict there…
I hope you’ll be able to deliver a fix soon :)
Cheers,
Česlav- This reply was modified 7 years, 9 months ago by bluechip1. Reason: grammar
Hi Rikard, yes, you can close this topic!
Hi Ismael,
Thanks for reply! I have edited the theme directly for now. I’ll submit these two as feature requests then and will hope that they’ll get included :) If not, I’ll resort to script re-queueing.
Cheers,
ČeslavHi again,
I have one more enhancement request :) Currently, Enfold enqueues comment-reply.min.js script even on pages that have comments disabled, because the if-condition is incomplete:
if ( is_singular() && get_option( 'thread_comments' ) ) { wp_enqueue_script( 'comment-reply' ); }
The if-condition should also include
comments_open()
check – see the corresponding code in TwentySeventeen for example: https://github.com/WordPress/twentyseventeen/blob/master/functions.php#L313-L315 This way, the script will not be unnecessarily loaded on pages/posts with comments disabled.Cheers,
ČeslavHi Yigit,
see the screenshot below:
The primary menu is still displayed despite the mobile menu is already active at given resolution. I use a child theme of Enfold, but only with minimum of adaptations and the Enfold (parent) theme is up to date (3.1.1 version).
Best regards,
Česlav -
AuthorPosts