Forum Replies Created
-
Posts
-
Hi Ismael,
We are ALMOST there – both types of links are working now BUT – the unlisted version with an existing URL parameter does not work. See code in private content below.
Thanks,
AndyMy apologies – I removed our domain but didn’t change the dropdown selection from ‘specific domains’ to ‘anywhere’. The videos should work for you now but I’ll go ahead and test the code and report back. Thanks!
Hi Ismael,
My apologies for the very stubborn cache. I cleared it, but you might still need to add a cache-busting URL param to the test URL, even in incognito.The Public link is working now but the unlisted isn’t. Screenshots in private content below.
Thanks,
AndyActually the code doesn’t appear to be capturing the unlisted format either now, which is baffling me. Maybe you can spot the issue? Please see private content below.
Hi Ismael,
OK great – it’s not currently working but that’s not on you. I need to adjust my site header permissions policy to get it to work.
Ismael, thank you so much for seeing this through. Your support is second to none! Will this be included in an upcoming update? I want to be sure the changes don’t get overridden.
Thanks again,
AndyHi Ismael,
It’s working now*, but you have a non-conditional?in the code, which means any existing URL parameter such as autoplay=1 gets dumped. Was that intentional?
Thanks,
Andy*I used a random cache-busting URL param and then a hard reload to get the updated script to load.
***Please move the image link to private***
I’m seeing your modified code in the Sources tab. And no, it still doesn’t work. Screenshot in private content.I added console.log(m) to the source and this is the result:
[‘https://vimeo.com/771743115/e732122dc0?iframe=true’, ‘https://’, undefined, undefined, undefined, ‘771743115’, ‘e732122dc0’, index: 0, input: ‘https://vimeo.com/771743115/e732122dc0?iframe=true’, groups: undefined]
0: “https://vimeo.com/771743115/e732122dc0?iframe=true”
1: “https://”
2: undefined
3: undefined
4: undefined
5: “771743115”
6: “e732122dc0”
groups: undefined
index: 0
input: “https://vimeo.com/771743115/e732122dc0?iframe=true”
length: 7
…
Also, I added console.log(id + id2 + ‘?’ + params) just after “params = params[1];” and it’s returning the same exact URL parameter (nothing changed).Hi Ismael,
It’s loading for me. When I check the script tag’s link (in private content below) I see the line you referencing and it looks identical to what I see in the source except for your // remark above it, but the actual regex match appears to be identical.1) yours from above, 2) served on page, 3) downloaded by me via Filezilla to review directly:
1: var m = url.match(/(https?:\/\/)?(www.)?(player.)?vimeo.com\/([a-z]*\/)*([0-9]{6,11})\/(\w{6,11})[?]?.*/), id, params;
2: var m = url.match(/(https?:\/\/)?(www.)?(player.)?vimeo.com\/([a-z]*\/)*([0-9]{6,11})\/(\w{6,11})[?]?.*/), id, params;
3: var m = url.match(/(https?:\/\/)?(www.)?(player.)?vimeo.com\/([a-z]*\/)*([0-9]{6,11})\/(\w{6,11})[?]?.*/), id, params;Am I missing something?
Hello Ismael,
It looks like the changes had no effect. Notes in the private content box below.
Thanks,
AndyHello Ismael,
My apologies, that’s a separate plugin that add contacts to Constant Contact and I hadn’t considered it to be the issue since it was working fine before. I’ll get it fixed. You may close this thread. Thank you!This might not be the right thread for this comment so please take it in the spirit it’s intended, but this shouldn’t be automatic, or at the very least there should be a hook that we can use to disable it. The “text-HTML” ratio is already extremely high with the Enfold theme (text-HTML ratio is a growing SEO factor – listed as warnings in SEMRush). This only makes it even more difficult to get past the threshold for pages that are high in design but low in content. In fact I’m here now because I just saw my SEMRush warnings skyrocket. Since the “SVG Support” plugin is widely used and already has that option, it would make sense to have an option to disable this in Enfold as well.
Thanks for the detailed response Günter. The patch does appear to have fixed many of the display issues I was encountering (I haven’t been able to check everything yet though). I still would like to see the ability to disable this as an option, at least while this is still getting fleshed out. It sounds like this new ‘feature’ is in an evolving state, so it would be nice to be able to op-out until a time when it’s least likely to break the display. Thank God for staging areas ;-) Thanks again.
As it turns out, the owner of the website forgot to generate the lat/long coordinates after they added the real estate property. No coordinates = map fail, BUT – the Enfold theme was reporting that the user hadn’t allowed cookies. Thus the rabbit-hole investigation into cookie consent. Apologies for the inconvenience and the round-around. You may close this thread now. Thanks for your time.
Still no joy. I cleared the server cache as well, and am viewing incognito. The map simply won’t load when it used to prior to the cookie update. Is there a way that I can copy the necessary file over to my child theme and disable the cookie consent that way?
Version 4.7.4 is not showing up as available in the Theme Update area, nor through the Envato Market plugin – in both areas it appears as up-to-date. Any idea when 4.7.4 will be added to the Envato Market repository?
Hello Yigit – that does not work. The map does not load because I’m using a direct shortcode call via PHP, and I need to be able to instruct Enfold to bypass the check. Here’s my code:
echo do_shortcode('[av_google_map height="400px" zoom="13" saturation="" hue="" zoom_control="aviaTBzoom_control" maptype_control="dropdown" maptype_id="" custom_class="" av_uid="av-k2kfwniz"] [av_gmap_location address="'.$address["street_address"].($address["address_line_2"]?", ".$address["address_line_2"]:NULL).'" city="'.$address["city"].'" country="USA" long="'.$address["lng"].'" lat="'.$address["lat"].'" marker="211" imagesize="40" av_uid="av-6uitn"]<strong>'. get_the_title($property->ID) . '</strong><br />' . $address["street_address"].($address["address_line_2"]?", ".$address["address_line_2"]:NULL) . '<br />'.$address['city'].', ' . $address['state'] .' ' . $address['zip'] . '[/av_gmap_location][/av_google_map]');I also wanted to add that the auto-responder is fired twice. When I var_dumped the $new_post content to the error log I saw 4 passes through the avf_form_mail_header filter; not 2 which is expected since avf_form_mail_header is included twice.
I realize this is an old post but the method “L” posted (post #789555) fails because the carriage returns in message headers need to be wrapped with double quotes, not single:
Incorrect:
$header .= 'Reply-To: ' . $enfold_custom_from_header . '\r\n';Correct:
$header .= 'Reply-To: ' . $enfold_custom_from_header . "\r\n";This method will also fail if auto-responders are being used because Enfold has the same filter used twice in the file class-form-generator.php: avf_form_mail_header. It’s included once for the message, and once for auto-responders which means it gets called twice, overwriting the header for both (undesirable!). These sections need to have 2 distinct sets of filters.
