Forum Replies Created
-
AuthorPosts
-
Thank you for the reply Ismael.
From what I can finally gather from the plugin provider’s website, they no longer support short code use with their non-pro version of the plugin.
I ended up modifying the template directly.
Thanks again.Mitchell
Hi Mike,
It was SiteGround’s plugin.
Mitch
I found the answer in another post about lazy loading. I turned it off in another plugin and the slider displayed as normal.
Is this going to be addressed in future releases so we can utilize lazy loading?
I’m seeing this issue as well where there is white space below the first slide on initial load along with the nav controls. After the first slide rotates out, everything displays as normal.
This started after upgrading to 4.8.8.1
Lazy loading is turned off and cache has been cleared on server and the client.Mitch
Thanks Mike,
I had fixed the issue and forgot to come back here and clean up the thread. Appreciate the help.
Mitch
March 5, 2021 at 4:53 pm in reply to: Fullscreen Slider disappears after installing Enfold 4.8 #1285839Yigit,
Thank you. That fixed the problem.
Mitch
Please go ahead and close this ticket.
Thank you.Victoria,
Thank you. That did the trick for now.
Mitch
July 2, 2020 at 12:40 pm in reply to: Accessibility issues with main nav leaves US sites in danger of lawsuits :( #1227464Thank you for your help Ismael,
I got the following to work for me:
wp_dequeue_script('avia-megamenu'); wp_enqueue_script('avia-megamenu', get_stylesheet_directory_uri().'/js/avia-snippet-megamenu.js', array('avia-default'), '', true);
June 30, 2020 at 12:51 am in reply to: Accessibility issues with main nav leaves US sites in danger of lawsuits :( #1226627dfpg,
The only way I could get it to work was to modify the parent theme file. Recreating the structure/file in my child theme wouldn’t take. The supplied code works. Now it’s just a parent/child issue.
Mitch
June 29, 2020 at 5:24 pm in reply to: Accessibility issues with main nav leaves US sites in danger of lawsuits :( #1226528Thank you Ismael,
How can I get this into a child theme so the changes aren’t overwritten with the next release?
Mitch
Mike,
There is a growing need to have a WCAG accessible base theme. If you could pass on the need for a skip link and this thread https://kriesi.at/support/topic/wcag-2-1-level-aa-and-landmarks/ to the developers, I would appreciate it. The base theme is already almost there. Just a handful of changes needed….
Yes. Please go ahead an close this thread.
Thanks again,
Mitch
June 27, 2020 at 11:18 pm in reply to: Accessibility issues with main nav leaves US sites in danger of lawsuits :( #1226145Ismael,
What we are looking for is for the sub menu to display when the top level menu item is tabbed to using tab on the keyboard. So if the main menu item has items underneath it, the list of sub-menu items should display just as if I hovered a mouse over the main menu item. From there I can simply keep tabbing down the list.
To see a working example, go to this page and use tab on your keyboard to cycle through the menu.
https://open.berkeley.edu/Mitch
Thank you Mike. I had to modify the header.php file anyway due to other non-accessible issues in the base enfold theme.
I just added the .insertAfter portion of the script to my existing script and will move on…
Thanks again.
Mitch
Mike,
Thanks but that doesn’t really help. Is the markup in the functions-enfold.php file in the avia_title function?
Mitch
Hello,
Here is a good example of how it should behave without having to add any JavaScript:
https://www.davidmacd.com/test/skipnav-tabindex.htmlThe only way I can get the tab order correct is to do the following:
1) Target an anchor tag with a name attribute and tabindex set:
<a id="maincontent" name="maincontent" tabindex="-1"></a>
2) Add some jQuery (as suggested) to set the input focus, not just the visual focus.
$(document).ready(function () { $(".jsf-skip-link").click(function(){ $("#maincontent").focus(); }); });
Targeting the #av_section_1 div with the above did not work.
Where can I inject my anchor to have it below the breadcrumb section?Thank you.
Mitch
-
This reply was modified 4 years, 2 months ago by
Mitchell Adams.
Thanks. I’ll take a look at your post. I may have to opt buying the other menu if the theme won’t support tab navigation.
Mike,
I targeted the DIV originally with no success. I set it back to target #main so you can see.
Mitch
Mike,
I’ve included a link to the site in the private content area.This site is what I modeled the skip link setup after:
https://knowbility.org/blog/2019/skip-links/I’ve included the following link directly after the opening body tag:
<a href="#maincontent" class="jsf-button jsf-skip-link">Skip to main content</a>
I have CSS applied to hide the link until on focus (after tabbing from address bar).
I’ve tried different targets (the div, a dedicated anchor) and adding tabindex=’-1′ with no success.
I’m having the same issue. Did this ever get solved?
To summarize my changes for others with the same issue, the following was made to Enfold version 4.7.5 to address nested landmarks and non-unique landmarks in my child theme.
File: page.php
Changed line 26 from
<main class='template-page content <?php avia_layout_class( 'content' ); ?> units' <?php avia_markup_helper(array('context' => 'content','post_type'=>'page'));?>>
to
<div class='template-page content <?php avia_layout_class( 'content' ); ?> units' <?php avia_markup_helper(array('context' => 'content','post_type'=>'page'));?>>
and on line 39, changed the closing </main> tag to a </div> tag.——————————–
File: header.php
Changed line 124 to have a role=’main’ attribute added:
<div id='main' role='main' class='all_colors' data-scroll-offset='<?php echo avia_header_setting('header_scroll_offset'); ?>'>
——————————–
File: includes/helper-main-menu.php
Changed line 71 to add an id and aria-label to the <nav> element to make it unique from the main site nav.
echo "<nav id='my_unique_id' aria-label='my_aria_label' class='sub_menu' ".avia_markup_helper(array('context' => 'nav', 'echo' => false)).">";
———————————
File: config-templatebuilder/avia-shortcodes/section.php
Created a ‘shortcodes’ folder in my child theme and copied the section.php file into the folder.Changed line 1336 from
$markup = 'main ' . avia_markup_helper( array( 'context' => 'content', 'echo' => false, 'custom_markup' => $custom_markup ) );
to
$markup = 'div ' . avia_markup_helper( array( 'echo' => false, 'custom_markup' => $custom_markup ) );
Changed line 1366 from
$close_markup = '</main><!-- close content main element -->';
to
$close_markup = '</div><!-- close content main element -->';
Finally, added the following function to the child theme functions.php file.
function avia_include_shortcode_template($paths) { $template_url = get_stylesheet_directory(); array_unshift($paths, $template_url.'/shortcodes/'); return $paths; } add_filter('avia_load_shortcodes', 'avia_include_shortcode_template', 15, 1);
———————————
Mitchell Adams
Hi Ismael,
Thank you for all your help. I had caught the syntax error and corrected it in my code. At any rate, it still doesn’t work so I’ll just stick with the hard code in the section.php file.
Is there any chance the landmark issue will be addressed in a future release? There is a large need for WCAG compliant WordPress themes out there. I would imagine there are also business opportunities with companies like Deque.
Mitch
Ismael,
Thanks for the link to the shortcodes documentation. I have that piece working.The ‘avf_markup_helper_attributes_modified’ function you sent over doesn’t want to take (I removed the extra parenthesis).
The only way I could get the ‘role’ attribute removed was to modify line 1336 in the section.php file and taking out the ‘context’ => ‘content’ array item.
Changing
$markup = 'main ' . avia_markup_helper( array( 'context' => 'content', 'echo' => false, 'custom_markup' => $custom_markup ) );
To
$markup = 'div ' . avia_markup_helper( array( 'echo' => false, 'custom_markup' => $custom_markup ) );
Should I just go that route instead of a function since I already have to modify section.php or will it introduce other complications?
Thanks
Mitch
MitchThank you Ismael,
I’ve copied the directory structure into my child theme but it doesn’t want to pick up the changes. Only modifying the parent theme file works. Are there other steps I need to take to be able to use the changes in a child theme so changes don’t get overwritten after an update?
Also, it appears the function ‘avia_markup_helper’ in the file ‘/includes/helper-markup.php’ is injecting ‘role=main’ which is also going to cause a conflict. Can line 69 of that file simply be commented out?
case 'content': $attributes['role'] = 'main'; $attributes['itemprop'] = 'mainContentOfPage';
Or should I delete the args from the section.php file?
Thank you.
Mitch
Hello Ismael,
Thank you for the help. I’ve applied those changes.The example page has a Color Section followed by a 1/1 column. It seems both of those generate HTML containing another <main> element which ends up forming nested <main> elements.
This HTML getting output is:
<main role="main" itemprop="mainContentOfPage" class="template-page content av-content-full alpha units">
See this documenation:
https://dequeuniversity.com/rules/axe/3.5/landmark-main-is-top-levelWhich files need to be modified to ensure only one <main> or <div role=’main’> element is present on the page?
Thank you.
Mitch
P.S. I’ve copied the page.php file into my child theme and it doesn’t appear to be used.
-
This reply was modified 4 years, 3 months ago by
Mitchell Adams. Reason: I noticed the page.php file in my child theme was not getting used
Hello Rikard,
Thank you for the reply. Yes. I am using the latest version. I started a new thread with the issues I’m working to address.
Mitchell
This reply has been marked as private.Thank you. That did the trick. Was this unique to our instance or will it be included in the next release?
Thanks again.
Hello,
I’ve included links to before and after images.
I’m viewing on Windows 10.
Chrome version Version 75.0.3770.100 (Official Build) (64-bit)
Edge version 44.17763.1.0
Firefox version 67.0.4 (64-bit)Chrome and Firefox behave the same way with no caption showing until a mouseover of the image.
Edge will show a caption but is not sized correctly until a mouseover.NOTE: If I remove the link on the slide, the caption displays normally.
This reply has been marked as private. -
This reply was modified 4 years, 2 months ago by
-
AuthorPosts