Tagged: bug, equal height, error, urgent
-
AuthorPosts
-
June 4, 2018 at 11:06 pm #966892
Dear Kriesi Support,
I need your support. I’ve been working with Enfold for years in several projects, but with one certain page I am clueless, what to do anymore. Please see private content section.
1. Issue: Equal height columns break into multiple rows:
– see playground link for you below
— example:
—- av_section_1 where 1/5 1/2 1/4 break into 1/5 4/5 1/1
—- av_section_3 where 2/3 and 1/3 break into 1/1 1/1
—- av_section_4 where 1/5 and 4/5 break into 1/1 1/1
– what I’ve been trying?
— already deactivatied and purged cache plugins and similar stuff
— already removed the code block at the very bottom
— created new columns and moved content from old to new columns and set up the new columns the same way2. Issue: Sometimes amendments to columns, like equal column height, padding, border width, etc. dont save.
The last version where we did not have the issue with the equal height columns was 3.8.5. We tried several times to update, but rolled back, since we were not able to find the issue or a solution.
Can you please check and advise?
June 5, 2018 at 9:08 am #967081I’ve been adding html comments to columns.php in order to see, which condition leads to the break and obviously it is:
`if( ! isset( $meta[‘siblings’][‘next’][‘tag’] ) )
Any idea, why there is no reference to the next sibling, when using equal height columns?
As dirty workaround for the moment I commented out line 1049 in config-templatebuilder/columns.php (// $force_close = true;), but this cannot be the solution. Why there is not meta siblings next tag set for these equal column height columns?
- This reply was modified 6 years, 6 months ago by mailworm.
June 6, 2018 at 3:41 pm #967907Hi,
Sorry for the late reply, I checked your site and tried to create equal height columns as per your description on a private test page (Link in private content). Everything worked fine I could not reproduce the issue you mentioned.
Sometimes in preview mode, the elements might not render correctly please save the page as a private page so only you can see it and check for the issue.
If you still have any issue please point us to the page where we can see the problem so we can help you better :)
Best regards,
VinayJune 8, 2018 at 3:07 pm #970098Hi Vinay,
thanks for testing. Actually with new pages created, the issue does not exist. It happens to existing pages. The pages were build with lots of effort, thus rebuilding them is the last option.
Please see private content for screenshots and for what I mean.
- This reply was modified 6 years, 6 months ago by mailworm.
June 11, 2018 at 10:32 am #971060Bump – please check & feedback to my latest response.
Thank you.
June 11, 2018 at 6:14 pm #971328Hi,
Sorry for the delay, Yes creating all the pages from scratch does not make any sense.
For testing purpose, please enable debug mode by adding the code provided in this link to your functions.php file which can be accessed from Appearance > Editor
This lets you view the shortcode for all the pages.
Copy the shortcode from a page and save it as a test page.
Let us know if this help!
Best regards,
Vinay- This reply was modified 6 years, 6 months ago by Vinay.
June 11, 2018 at 9:34 pm #971401No, this does not help. The issue is the same.
June 14, 2018 at 12:25 am #972550Hi,
Thank you for the update. Please try to run the shortcode parser to regenerate the shortcodes and repair the shortcode tree. More info in the documentation.
// https://kriesi.at/documentation/enfold/intro-to-advanced-layout-builder/#shortcode-parser
Let us know if it helps.
Best regards,
IsmaelJune 14, 2018 at 9:58 am #972731Hi Ismael,
already did this. On the live-site homepage 3 errors were detected and said to be fixed. With the test-page created from the shortcodes copied from the live-site homepages ALB field and pasted into the test-page the ALB / shortcode parser says:
Show Parser Info
No errors were detected parsing the shortcodes.“Reset” the code in columns.php (uncommenting $force_close = true) still results in breaking equal height columns (same like in the pictures posted previously in private content). :-(
Still uncertain, why nothing helps. And still not willing to recreate every single page (50+ pages). :-(
- This reply was modified 6 years, 6 months ago by mailworm.
June 18, 2018 at 9:39 am #974114Hi,
Thanks for the update.
1.) The columns inside the first section don’t break into multiple rows even when it is set to “Equal Height”. I removed the comment from line 1049 so $force_close is set to “true”. The columns have the sibling meta when I checked your variable dump.
["siblings"]=> array(2) { ["next"]=> array(3) { ["tag"]=> string(13) "av_one_fourth" ["content"]=> array(1) { [0]=> array(3) { ["tag"]=> string(11) "av_iconlist" ["content"]=> array(0) { } ["index"]=> int(10) } } ["index"]=> int(9) } ["prev"]=> array(3) { ["tag"]=> string(12) "av_one_fifth" ["content"]=> array(1) { [0]=> array(3) { ["tag"]=> string(12) "av_font_icon" ["content"]=> array(0) { } ["index"]=> int(2) } } ["index"]=> int(1) } }
2.) The changes display immediately when I adjust the column options. I set the padding value to 50px.
Best regards,
IsmaelJune 20, 2018 at 3:48 pm #975356Hi Ismael,
your advice did not help, however we found the reason for the column breaks, though it makes no sense to me, why it happens.In the first section, which is repeated on all pages, we used to have one H3 tag modified in CSS. We used :before to have an icon in front of this heading.
I still don’t get, how modified / custom CSS can take effect on PHP, but it was like that.
Here’s the code of the H3 element (which was located within a 1/2 equal height column, where the row was like 1/4 1/2 1/5):
<div style="padding-bottom:0px; color:#006ab3;" class="av-special-heading av-special-heading-h3 custom-color-heading blockquote modern-quote avia-builder-el-6 el_after_av_heading avia-builder-el-last sh_20 hotline "> <h3 class="av-special-heading-tag " itemprop="headline">24h-Hotline: 123 456 789 01</h3> <div class="special-heading-border"><div class="special-heading-inner-border" style="border-color:#006ab3"></div></div> </div>
And this was the CSS assigned through classes sh_20 and hotline:
.av-special-heading.sh_20 { margin-top: 20px; } /* Header Hotline Highlight */ body .av-special-heading.hotline { background: #006ab3; color: #ffffff !important; display: inline-block; border-radius: 3px; } body .av-special-heading.hotline .av-special-heading-tag { padding: 7px 10px; } body .av-special-heading.hotline .av-special-heading-tag:before { font-family: "custom"; content: "\e801"; display: inline; margin-right: 10px; }
1) I find it very critical, that custom CSS has impact und how PHP code is ran or whatever the reason was for the code not to have values in the siblings-arrays.
2) One would understand the behaviour, if the equal height column break would have happened only to the section with the custom CSS. However the same took effect on the content as a whole – even other sections with equal height columns were affected.- This reply was modified 6 years, 6 months ago by mailworm.
June 21, 2018 at 1:19 am #975594Hi,
Thanks for the update.
I’m sorry. I don’t think you think you understand me. Actually, I was not able to reproduce the issue as described in my previous reply and I don’t think the css breaks the structure. The columns don’t break into multiple rows when “Equal Height” option is enabled and the changes take effect immediately.
Best regards,
Ismael -
AuthorPosts
- You must be logged in to reply to this topic.