-
AuthorPosts
-
July 18, 2017 at 12:35 pm #823237
Hi team.
Any reason you’d remove the #menu-item-x IDs from the burger menu? Was this in error?
Cheers,
JoeJuly 18, 2017 at 12:40 pm #823240Custom classes added in Appearance > Menu are also not carried through to the burger menu.
July 18, 2017 at 9:19 pm #823493Also wondering why li#menu-item- IDs are not applied to the burger menu. Thanks!
July 20, 2017 at 4:08 pm #824661Hi JoeLovell,
Do you need help with anything in particular? Something broke. I’ve seen some instances still having those classes, some not.
Best regards,
VictoriaJuly 21, 2017 at 5:04 pm #825182Hi Victoria,
Thanks, yes I’d like some help. Is this a permanent ‘break’ or something you’ll be fixing so that I can implement a temporary fix on my sites or take a new approach to targeting burger menu items.
So Q 1: will you be bringing IDs back to burger menu items?
Q 2: Will you be taking notice of users adding custom CSS classes to menu items in Appearance > Menu so that their classes are added to the html output?
Q 3: Has anything else broken in the process? I had a filter on avia_append_burger_menu that no longer works since the last theme update (see below). Now it just results in a blank li item.Code:
//add search to burger menu add_filter( 'wp_nav_menu_items', 'avia_append_burger_menu', 9998, 2 ); add_filter( 'avf_fallback_menu_items', 'avia_append_burger_menu', 9998, 2 ); function avia_append_burger_menu ( $items, $args ) { if(!avia_is_burger_menu()) return $items; if ((is_object($args) && $args->theme_location == 'avia') || (is_string($args) && $args = "fallback_menu")) { $items .= '<li id="menu-item-burger" class="av-burger-menu-main menu-item-avia-special"> <a href="#"> <span class="av-hamburger av-hamburger--spin av-js-hamburger"> <span class="av-hamburger-box"> <span class="av-hamburger-inner"></span> <strong>'.__('Menu','avia_framework').'</strong> </span> </span> </a> </li>'; $items .= '<li class="menu-item menu-item-search">'; $items .= '<form action="https://www.domain.com/" id="searchform" method="get" class=""> <div style="opacity:1;display:block"> <input type="submit" value="" id="searchsubmit" class="button avia-font-entypo-fontello"> <input type="text" id="s" name="s" value="" placeholder="Search"> </div> </form>'; $items .= '</li>'; } return $items; }
Thanks Victoria!
Best wishes,
Joe- This reply was modified 7 years, 3 months ago by JoeLovell.
July 26, 2017 at 7:15 pm #830309Hi,
We have pointed out both issues to Kriesi, so he can take a look.
We would although appreciate a small patience, so he can go ahead and take everything under control as the updates and all the bugs are been control.Thank you so much for your input and patience, we are hambled and we much appreciate.
Thank you
Best regards,
Basilis -
AuthorPosts
- You must be logged in to reply to this topic.