prevent multiple (and blank) h1 w/ functions-enfold.php

Hello,

Just a recommendation for a minor “bug”.

Around line 403 of functions-enfold.php the site “removes the heading” if you are using breadcrumbs with title off (select “Display only breadcrumbs’ in Layout > Title Bar Settings.

if($header_settings['header_title_bar'] == 'breadcrumbs_only') $args['title'] = '';
This simply makes the <h1> blank, but this is no good since it creates a useless HTML tag and usually 2 <h1>s where not appropriate. A blank <h1> (and likely extra) in the code could be semantically confusing to search engines since this is the first <h1> present, but it is also certainly not necessary or useful in any case.

I replaced that line in my version with the following code, so this wouldn’t happen.
if($header_settings['header_title_bar'] == 'breadcrumbs_only') $args['html'] = "<div class='{class} title_container'><div class='container'>{additions}</div></div>";

I recommend the newest theme update include a similar (or better) fix for this so I can get rid of my custom functions file!

Thank you!

• This topic was modified 7 years, 9 months ago by ajmihalic4.