Codeblock unescaping escaped HTML

Rikard,

Sites internal but this is what I have figured out so far.

I had to switch to Advanced Layout to add an Advanced LayerSlider so it was full width header but I would have preferred to just have an two Layout settings added just like you do for sidebar settings on each page/post. One for:

LayeredSlider Heading
LayeredSlider Footing

Or even just some shortcode code you can add to the Heading and Footing that are full width, so we did not have to switch to Advanced Layout.

Anyways: If you create a text code or code block with the following, after you update the escaped HTML is removed.

1. Stop Watch Folder Service. (Start – Programs – PEERNET Document Conversion Service 2.0 – Watch Folder – Stop Watch Folder Service)
2. Open Watch Folder configuration file. (Start – Programs – PEERNET Document Conversion Service 2.0 – Watch Folder – Configure Watch Folder Settings)
3. Add the following lines:
   • <add Name=”Microsoft.Word.Document.PrintOut.Item” Value=”DocumentAndMarkup” />
   • <add Name=”Microsoft.Word.PageSetup.TwoPagesOnOne” Value=”True” />
   • <add Name=”Microsoft.Word.ReplaceFieldDateWith” Value=”***DATE***” />
   • For a complete list of settings and values, see Word Converter Options in the User Guide.

What I found out this morning is If you put a space between the ‘<add’ and code it as ‘< add’ as shown below. Then in at least text block, the HTML remains escaped but why (did not test code block yet)?

1. Stop Watch Folder Service. (Start – Programs – PEERNET Document Conversion Service 2.0 – Watch Folder – Stop Watch Folder Service)
2. Open Watch Folder configuration file. (Start – Programs – PEERNET Document Conversion Service 2.0 – Watch Folder – Configure Watch Folder Settings)
3. Add the following lines:
   • < add Name=”Microsoft.Word.Document.PrintOut.Item” Value=”DocumentAndMarkup” />
   • < add Name=”Microsoft.Word.PageSetup.TwoPagesOnOne” Value=”True” />
   • < add Name=”Microsoft.Word.ReplaceFieldDateWith” Value=”***DATE***” />
   • For a complete list of settings and values, see Word Converter Options in the User Guide.

So it appears the < needs a space following it to keep it escaped. But why?????

Also, do not understand why a Code Block in advanced layout is doing anything to the HTML/CSS/Javascript. It should just be a raw dump of what is inside the element but it keeps parse it and not treat it as a RAW element.

I need it to be RAW!!!!

I did figure out how to enable the post navigation by overriding avia_post_nav in my child theme and commenting out:

//dont display if a fullscreen slider is available since they overlap
// if((class_exists(‘avia_sc_layerslider’) && !empty(avia_sc_layerslider::$slide_count)) ||
// class_exists(‘avia_sc_slider_full’) && !empty(avia_sc_slider_full::$slide_count) ) $settings[‘is_fullwidth’] = true;

This following code is wrong!!!!!

/**
* takes some text in shortcode format (eg: [avia_textblock]this is test[/avia_textblock]) and converts it to an editable element on
* the AviaBuilder canvas. only executed at page load or when the editor is switched from default wordpress to avia builder
*/
convertTextToInterface: function(text)
{
if(this.activeStatus.val() != “active”) return;

this.body_container.addClass(‘avia-advanced-editor-enabled’);

var obj = this, editor;

if(typeof text == “undefined”)
{
text = this.secureContent.val(); //testdrive: val() to html()
if(text.indexOf(‘[‘) === -1)
{
text = this.classic_textarea.val(); //testdrive: val() to html()
if(this.tiny_active) text = window.switchEditors._wp_Nop(text);
this.secureContent.val(text);
}
}

// if(this.tiny_active) text = window.switchEditors._wp_Nop(text); // moved up 5 lines in order to fix this: https://github.com/AviaThemes/wp-themes/issues/573

//sends the request. calls the the wp_ajax_avia_ajax_fetch_shortcode php function
$.ajax({
type: “POST”,
url: ajaxurl,
data:
{
action: ‘avia_ajax_text_to_interface’,
text: text
},
success: function(response)
{
$(‘#content-tmce’).trigger(‘click’);
obj.sendToAdvancedEditor(response);
//obj.updateTextarea(); //dont update textarea on load, only when elements got edited
obj.canvas.removeClass(‘preloading’);
obj.do_history_snapshot();
}
});

—————————–

The line:
text = this.secureContent.val(); //testdrive: val() to html()

Should be:
text = this.secureContent.html(); //testdrive: val() to html()

I can see many val() to html() testdrive comments, but for sure this needs to be in html format for the POST operation.

I know that the issue is around the fact certain elements are not htmlentities when html stream is created for the advanced editor.

I did get it to work somewhat correctly but there is no clear documentation about the config-templatebuilder library so it’s hard to get all the paths correct.

So even though I could correctly get textblock and codeblock to work. When saving sometimes one or two of these entities would be encoded wrong leading to loss of information again.

So basiclly, I can not use config-templatebuilder (Advanced Layout) tool. It’s just does not function properly.

So I am no longer going to use this part of Enfold. Only editor that works properly is the Classic Editor!!!!!

Yes, I did wrap the code in sperate blocks and can get it to partly work but then I lose my spans that highlight elements in the code block.

The fact is the architecture of the component editors are wrong. If you had followed the technique the tinyMCE used it would have worked but the fact is this component does not.

The tinyMCE encodes the data in htmlentities format from the server side so that escaped html is not interpreted by the browser when embedded in the textarea.

The templatebuilder does not and this is where everything starts to break down.

I as said: I started to fix this issue properly but ran into two issues when testing. The tab/editor protocol is different in some way from the textcode/codeblock to editor functionality so did not operate correctly. And on save, still was getting random lose of information on some elements but this in my lack of understanding the save process and probably could have figuire it out in another day.

The fact remains, any escaped html will not remain intact because the browsers are transforming them back to unescaped format.

I agree that you can use it if you stick to just plain HTML and do not do anything fancy. But I expected more.

If I do go ahead an make improvements, how do I share the code changes back to you?