-
AuthorPosts
-
March 20, 2019 at 5:51 pm #1080934
Hello,
There’s an issue with the Icon List element. After update 4.5.5 the left aligned Big List shows the correct styling in the preview but doesn’t display properly on the site. In the screenshot, the left list is correct and the right list should have the same styling. Again this just changed after the update, this being a live site I had to revert. Link to image in private content, go to homepage of this link to see example of how it should be as I reverted to the previous version of Enfold.Thank you!
ChrisMarch 20, 2019 at 6:26 pm #1080940can confirm that- for my edited ALB Elements i just want to update – because of new code in 4.5.5
but right positioning of list elements ( and small lists ) do not take custom sizeguess it is the lines before line 540 ;)
these lines are missing:
$this->icon_html_styling = ''; $this->title_styling = ''; $this->content_styling = ''; $this->content_class = ''; $this->title_class = ''; $this->iconlist_styling = '';
March 20, 2019 at 6:37 pm #1080944Same at my site. Before update, all was ok. With new update, first icon ok, next have no colors. Corrupt. Thanks. How long should we wait now? A week?
W3C check send massive errors<div style=” style=” background-color:=”” border:1px=”” solid=”” color:=”” class=”iconlist_icon avia-font-flaticon”><span class=”iconlist-char ” aria-hidden=”true” data-av_icon=”” data-av_iconfont=”flaticon”></span></div>
March 20, 2019 at 6:40 pm #1080948Additional style tag is defined. massive. on many pages
March 20, 2019 at 6:51 pm #1080953but i think this is not the right way –
guess the lines on top should replace those lines – ???public function __construct( $builder ) { $this->screen_options = array(); $this->icon_html_styling = ''; $this->title_styling = ''; $this->content_styling = ''; $this->content_class = ''; $this->title_class = ''; $this->iconlist_styling = ''; parent::__construct( $builder ); }
but only with the missing lines above it will work ?
so – a mod has to look overMarch 20, 2019 at 6:58 pm #1080959Ok, thanks Günni, this works fine
March 22, 2019 at 5:48 pm #1081954PLEASE, REPLIES FROM ENFOLD SUPPORT ONLY, PLEASE START YOUR OWN THREAD IF YOU HAVE AN ISSUE
Still looking for help from Enfold support staff, thank you!
March 24, 2019 at 3:22 am #1082207Hi,
Thank you for contacting us.
You may not see the changes until the cached files are cleared in your browser.
Please perform the below steps to clear the browser cache:
1. Disable “merging and compression” for CSS and JS files from Enfold > Performance.
2. If a caching plugin is installed check the plugin settings and clear the cache and deactivate the plugins for testing purpose.
3. Hard refresh by pressing Ctrl + Shift + F5 on your browser or press the F12 key to open chrome dev tools and right click on the refresh button and select “Empty Cache and Hard Reload”.
If yous till have any issue please provide a precise link to the page, showing the elements in question? We need to be able to inspect them in order to help :)
Best regards,
VinayMarch 24, 2019 at 8:18 pm #1082360hm
I could have sworn that I precisely had this problem with the new version 4.5.5. Of course, I always update all cache settings – due to the background image problem, the merging was even disabled, but even then I created new css and js files.
I don’t know why it doesn’t occur anymore. ?March 25, 2019 at 11:21 am #1082609by the way: why is it needed / necessary to have
/** * * @since 4.5.5 * @var array */ protected $screen_options;
etc. pp on iconlist but not on iconbox ?
March 25, 2019 at 3:43 pm #1082712Hi Vinay!
Nothing worked. Noticed something, even if I clone the left column that has the red text the way it’s supposed to be, it turns grey and loses other styling. Including credentials in private content.
Thank you!
ChrisMarch 25, 2019 at 6:23 pm #1082787Dear Vinay,
i had the exact same problem as “ind-image”
Günni delivered the right solution by delivering the “right” file with modifications. That solved the problem for me.
@ ind-image: Open the dev-Console, inspect code and move the mouse over the second right column with icon. You will see, a style tag is duplicated and marked with a “!”. Or take a look into source code, and search for
div style=” style=”
Günni is a very experienced user. Sad, that you don’t accept the solution. The forums lives from dialogue with users. The same problem as yours was fixed in minutes. You wait days. Topics with same backgorund must not duplicaed. Issues with same problems can be solved in one topic. This relieves the support team.- This reply was modified 5 years, 7 months ago by Hokuspokus.
March 25, 2019 at 6:44 pm #1082795Hi Hokuspokus,
I understand what you are saying, but I have over thirty sites that use Enfold and manage many more, I don’t have the time to go in and fix code that shouldn’t be broken, I’ll revert and wait for a fix.
Thank you
March 25, 2019 at 7:16 pm #1082804I see we have the same pain. Enfold isn’t very suitable for agencies, because bug fixes aren’t captured and aren’t played in promptly via a patcher, for example, as with Awada. Enfold always takes too much time here.
And the solution from the support & cache: That’s pretty silly. Every experienced dev would have compared both files and recognized the error instead of spending the time to write a description to clear the cache. This is pretty embarrassing.- This reply was modified 5 years, 7 months ago by Hokuspokus.
March 26, 2019 at 3:14 pm #1083126I also have this problem — updated Enfold yesterday and many of my icons lost their color. See careers.bju.edu/home for an example. In the section above STUDENTS the first list of icons are blue but the others have reverted to gray, also the text associated with them has become gray. The icons in the student section were all a matching light blue but have become gray also. The color settings are correct in the icon color settings area. Something has been broken here in this update. Please advise. Thanks.
March 26, 2019 at 7:28 pm #1083213Hi BJUCareers,
Have you tried the code posted earlier in this thread?
Best regards,
VictoriaMarch 26, 2019 at 7:45 pm #1083223Please add the fix to the new version. Thank you!
March 26, 2019 at 8:53 pm #1083256What code are your referring to?
March 26, 2019 at 9:20 pm #1083263see here about my comment: https://kriesi.at/support/topic/icon-list-element-issue/#post-1082360
it seems to be solved over night :
don’t know – becaue i have done all that vinay said. Try again to make it step by step.
disable merging – refresh – merge again etc.March 28, 2019 at 4:22 pm #1084161Hi Chris,
We will include the fix in upcoming update.
For anyone else having the same issue and would like to apply temporary fix, please refer to Günter’s post here – https://kriesi.at/support/topic/possible-css-rendering-bug-in-4-5-5/#post-1083761
Regards,
YigitMarch 28, 2019 at 9:08 pm #1084274is that last line obsolete of Günter?
see here my comment: https://kriesi.at/support/topic/icon-list-element-issue/#post-1080940On original source code the iconlist_styling is set to:
$this->iconlist_styling = $iconlist_styling == 'av-iconlist-small' ? "av-iconlist-small" : "av-iconlist-big";
so i think this will be enough to insert. ?
$this->icon_html_styling = ''; $this->title_styling = ''; $this->content_styling = ''; $this->content_class = ''; $this->title_class = '';
see here my comment: https://kriesi.at/support/topic/icon-list-element-issue/#post-1080940
April 1, 2019 at 4:35 pm #1085572Hi!
@guenni007 Günter said initialising all variables at a place and making sure they have a valid value is a good practise. To make code easier to read and to help keep it more stable, in case someone removes the second line and later adds a string you get noticesRegards,
YigitApril 1, 2019 at 4:57 pm #1085579Thanks – I’m still a learner.
here i know that all variables had to be mentioned:
extract( shortcode_atts( array( 'position' => 'left', 'color' => '', 'custom_bg' => '', 'custom_border' => '', 'custom_font' => '', 'font_color' => "", 'custom_title' => '', 'custom_title_tag' => '', 'custom_content' => '', 'custom_title_size' => '', 'custom_content_size' => '', 'iconlist_styling' => '', 'animation' => ''
but for me this just looked more liquid than liquid – so to speak superfluous
$this->iconlist_styling = ''; $this->iconlist_styling = $iconlist_styling == 'av-iconlist-small' ? "av-iconlist-small" : "av-iconlist-big";
can be closed from my point of view.
-
AuthorPosts
- The topic ‘Icon List Element Issue’ is closed to new replies.