Viewing 10 posts - 1 through 10 (of 10 total)
  • Author
    Posts
  • #510985

    Tamara Zuk

    Hey there,

    We contacted you last week at (Email address hidden if logged out) but haven’t received a response yet. Below is my email:

    My name is Tamara and I work at SkyVerge where we build some of the top WooCommerce extensions, including WooCommerce Tab Manager.

    We’ve received a number of complaints from customers regarding a conflict with the Enfold them. A few of them pointed us to the following threads:

    https://kriesi.at/support/topic/ (Purchase code hidden if logged out) -manager/
    https://kriesi.at/support/topic/ (Purchase code hidden if logged out) -plugin/

    It’s never a good idea to directly edit plugins as any changes made would be lost when updating.

    We took the time to debug this issue and have narrowed it down to the save_post() method in config-templatebuilder/avia-template-builder/php/meta-box.class.php. The specific issue is in the following chunk of code on line 214:

    https://cloudup.com/cR6JwHQH80n

    Since our meta is named _override_tab_layout, the strpos() returns an integer value which updates the post meta with “on” rather than the WooCommerce standard “yes” value. You should change this line to strict equality check, $box['id'] === $key, to avoid conflicts with other plugins.

    Please let me know when you will be fixing this issue so I can notify our customers.

    Thanks :)


    Tamara

    #511010

    Hi Tamara Zuk!

    Thanks a lot for letting us know! It is amazing to have other devs contact and help with the compatibility.
    We will be adding that to our github now and will also notify kriesi!

    Thanks!

    Best regards,
    Basilis

    #511041

    Tamara Zuk

    Hi Basilis,

    Thanks so much for the quick reply! Once you have a better idea for when this fix will be released to your customers, could you please let me know?

    Thanks again,

    Tamara

    #512473

    Hey Tamara,

    I am keeping a track of it but I can not know when it can be done.
    I will try to make sure to push it into the issues of git to the top place, so we can work it out fast! :)

    Regards,
    Basilis

    #523372

    Tamara Zuk

    I’m not a dev and trying to solve this same issue. Could you post the exact syntax for line 214? I’ve made what I thought was the correct adjustment, but it’s still not working.

    Thanks,
    -Andy

    #524059

    Tamara Zuk

    I’m not a dev and trying to solve this same issue. Could you post the exact syntax for line 214? I’ve made what I thought was the correct adjustment, but it’s still not working.

    Thanks,
    -Andy

    #524645

    Hi!

    This is the code on line 214 of config-templatebuilder/avia-template-builder/php/meta-box.class.php file:

    if(strpos($key, $box['id']) !== false)
    

    This is the line from 212 to 218 in case you want to know:

    foreach($_POST as $key=>$value)
    				{
    					if(strpos($key, $box['id']) !== false)
    					{							
    						update_post_meta($id , $key, $_POST[$key]);					
    					}
    				}

    Regards,
    Ismael

    #524655

    Tamara Zuk

    Hi Ismael,

    I didn’t post the last two entires. My last post was on Sept 29.

    It looks like anyone can post on this thread and it gets added as a reply from the original poster. An email or a name is not asked for either, so it looks like your system assumes all queries are from the OP.

    Is there any way to delete or change the name for the two entries? Also, could you close out this thread?

    Thanks!

    Tamara

    #524669

    Hey!

    Topic closed.

    Best regards,
    Basilis

    #529657

    Hi Tamara!

    Was finally able to do the required bugfixes. I am not even sure why there is a strpos check instead of an === in the first place so thanks for pointing that out. It will be fixed in the next version, coming during the next few days :)

    Best regards,
    Kriesi

Viewing 10 posts - 1 through 10 (of 10 total)

The topic ‘BUG REPORT: WooCommerce Tab Manager conflict’ is closed to new replies.